Use more informative check_arg #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwiernik
reviewed
Oct 18, 2024
Co-authored-by: Brenton M. Wiernik <[email protected]>
|
Maybe, when we have this wording, it would make sense to remove the suggested options from those that follow after "Otherwise...". Else, they would be duplicated. |
|
Good call |
|
I added that function to insight, so we can use it in other packages, too: library(insight)
foo1 <- function(test = "short_distance") {
validate_argument(test, c("short_distance", "long_distance", "medium_distance"))
}
# match
foo1("medium_distance")
#> [1] "medium_distance"
# typo
foo1("medium_ditsance")
#> Error: Invalid option for argument `test`. Did you mean "medium_distance"?
#> Otherwise, use one of the following options: "short_distance" or
#> "long_distance"
# no match
foo1("abcabcabc")
#> Error: Invalid option for argument `test`. Please use one of the following
#> options: "short_distance", "long_distance" or "medium_distance"Created on 2024-10-19 with reprex v2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.